-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCP_CLOUD_RUN_JOB execution mode #1153
Conversation
✅ Deploy Preview for sunny-pastelito-5ecb04 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @ags-de, Thank you so much for your contribution. Please let us know if you need any support. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
+ Coverage 95.72% 95.77% +0.05%
==========================================
Files 64 65 +1
Lines 3672 3744 +72
==========================================
+ Hits 3515 3586 +71
- Misses 157 158 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
855dba3
to
e30de3b
Compare
@ags-de thank you very much for working so quickly on the changes requested. When you get a chance, please, rebase on the main branch. |
db25ad2
to
ab2f009
Compare
ab2f009
to
5dcec92
Compare
342a7bf
to
0bb09a1
Compare
51b8a24
to
e55bc97
Compare
e55bc97
to
8e549ca
Compare
Hello @tatiana, The branch is rebased and I also fixed a few typos in docs. It should be ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ags-de amazing work!
I left one last comment. I'll wait for your feedback/change before we merge into the main branch.
Co-authored-by: Tatiana Al-Chueyr <[email protected]>
Added new `GCP_CLOUD_RUN_JOB` execution mode that triggers Google Cloud Platform's Cloud Run Job instance with dbt model in it. It extends Airflow's `CloudRunExecuteJobOperator` and overrides Cloud Run Job's container with dbt command generated by cosmos. Note: `CloudRunExecuteJobOperator` has `container_overrides` parameter implemented in `apache-airflow-providers-google==10.13.0` which is supported by `airflow >=2.6.0`. Resolves astronomer#1149 Co-authored-by: Agata Zalewska <[email protected]> Co-authored-by: Tatiana Al-Chueyr <[email protected]>
Description
Added new
GCP_CLOUD_RUN_JOB
execution mode that triggers Google Cloud Platform's Cloud Run Job instance with dbt model in it.It extends Airflow's
CloudRunExecuteJobOperator
and overrides Cloud Run Job's container with dbt command generated by cosmos.Note:
CloudRunExecuteJobOperator
hascontainer_overrides
parameter implemented inapache-airflow-providers-google==10.13.0
which is supported byairflow >=2.6.0
.Related Issue(s)
resolves #1149
Breaking Change?
None, the new execution mode is optional.
Checklist